Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@clack/prompts): dynamic max items #174

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Mist3rBru
Copy link
Contributor

@Mist3rBru Mist3rBru commented Oct 4, 2023

This PR introduces a maxItems calculation based on available terminal rows. This ensures a responsive display, preventing issues caused by lists that might exceed the terminal's row capacity.

Demo

2024-02-23_12-04-31.mov

Closes #173

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: f33a56f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mist3rBru Mist3rBru changed the title feat(@clack/prompts): add adaptative max items feat(@clack/prompts): dynamic max items Nov 10, 2023
@cpreston321
Copy link
Collaborator

LGTM

@cpreston321 cpreston321 self-requested a review March 20, 2024 14:28
@cpreston321 cpreston321 merged commit e74d448 into bombshell-dev:main Mar 20, 2024
2 checks passed
@Mist3rBru Mist3rBru deleted the adaptative-max-items branch March 20, 2024 15:53
exdeniz added a commit to exdeniz/better-commits that referenced this pull request May 8, 2024
Fixed glitch on small height screen for long scopes list. Base on @clack/prompts@0.7.0 via bombshell-dev/clack#174
Everduin94 pushed a commit to Everduin94/better-commits that referenced this pull request May 8, 2024
Fixed glitch on small height screen for long scopes list. Base on @clack/prompts@0.7.0 via bombshell-dev/clack#174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Long select list glitches
2 participants