Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isAllowEmpty in multi-select prompt #42

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Support isAllowEmpty in multi-select prompt #42

merged 4 commits into from
Feb 17, 2023

Conversation

jinmayamashita
Copy link
Contributor

close #41

It would be a little more flexible if we could use empty arrays in the multi-select prompt.
First, I think simply be used as an option (any thoughts are welcome)

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: 45ceace

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/prompts Patch
@clack/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think required would be a better name for this, do you mind updating the PR?

packages/core/src/prompts/multi-select.ts Outdated Show resolved Hide resolved
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@jinmayamashita jinmayamashita marked this pull request as draft February 17, 2023 02:39
@jinmayamashita
Copy link
Contributor Author

Check operation 👀

required: true / undefined

Kapture.2023-02-17.at.12.10.48.mp4

required: false

Kapture.2023-02-17.at.12.11.42.mp4

@jinmayamashita jinmayamashita marked this pull request as ready for review February 17, 2023 03:14
Copy link
Collaborator

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the updates!

@natemoo-re natemoo-re merged commit dec4728 into bombshell-dev:main Feb 17, 2023
@jinmayamashita jinmayamashita deleted the feat/support-is-allow-empty branch February 17, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Allowing empty array in multi-select prompt
2 participants