-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A variant with extra apps only? #34
Comments
Hello @DarthWound
The The problem is that, Adwaita's hierarchy is always |
All the folders.
Nope. But maybe I was wrong for this point sorry. Some panel icons aren't ok though, like the GNOME Tweaks symbolic which is now different in Adwaita, or network icon as you use the one from Papirus.
I don't remember right now, but some of them changed in 3.34-3.36, sometimes it's just a subtle change like shadow or color correction, but it's still important.
I meant just add Adwaita in the inherits list if you make a variant with only extra apps, so it will use the standard Adwaita for other existing icons.
Yeah, but they are working on it, some of them were already improved in 3.34-3.36, and anyway if we have a variant that follows upstream it doesn't matter that much. Just to be sure that you understand what I am suggesting, it would be just a theme that adds icons for missing third-party programs without modifying the original Adwaita set. A few examples of differences between Adwaita and Adwaita++ (Fedora 31 & GNOME 3.34): |
Hello @DarthWound @Bonandry does not like to follow Adwaita's GNOME developers rules. But I will negotiate with him. If he agrees, I will reform the icons themes, paying attention to the whole Adwaita project.
Ah, only the third-party icons who do not exist on the original Adwaita icons theme, and no need to add all the icons as the Adwaita has already. But is it possible that it inherit from the original Adwaita icons theme if it uses SVG and original Adwaita uses PNG, and they have different hierarchies? There are three problems:
|
Yes I know haha 😆 same "problem" with Yaru++, but imo a "++" theme should only add missing stuff to vanilla, not modify it too much. It's why I'm suggesting a more upstream-friendly variant. But I didn't ask to give up the current work, just offer another variant for people who prefer the original Adwaita. And there are a lot.
Exactly!
Good question, I don't know. In worst case scenario, maybe provide existing icons in SVG but don't modify them and keep them up-to-date with upstream.
If an user wants to change folder colors, then he uses the current Adwaita++ with its modified folders.
Same answer than the previous one.
An user that wants an upstream-friendly Adwaita++ probably already has the original Adwaita installed. And if not, I don't think it's complicated for a Void (or Arch/whatever) user to type I don't want to annoy you, it's just that a lot of users like vanilla icons (Adwaita or Yaru) and just need missing programs to have a consistent look. And I'm one of them. For example, look at what @varlesh (from Papirus Team) did in breeze-extra, he's added (and slightly improved) some icons but didn't change the original Breeze theme, and that's enough to have an excellent enhanced Breeze in KDE. |
@DarthWound I need to think strategically how to reorganise the Adwaita++ themes, if @Bonandry does not agree: We will have two repositories:
What do you think? |
Sounds great! But why the Breeze icons in "Adwaita++ Minimal"? Maybe you misunderstood me, I wasn't telling you to add them, it was just an example of what varlesh did, Breeze with more icons without altering it. |
The original Adwaita is not fully supported in KDE. It does not have many KDE actions, apps and status icons. The most important observation is that, I have upgraded the battery icons because @btd1337 found the current battery icons of original Adwaita ugly and old-fashioned, he hates them. He also hates the old legacy icons. I have been discussing the legacy icons which are old-fashioned with the people from Ubuntu's original Yaru, you can see our discussion: @Feichtmeier and @madsrh have decided to upgrade the legacy icons still used by modern apps as Inkscape, Meld and Transmission. You can see another discussion: |
I'm not sure if it's really needed. GNOME and KDE design guidelines are really different, mixing Adwaita and Breeze sounds weird. And it adds much more work to maintain everything. At least maybe "Adwaita++ Minimal" should only focus on GNOME (or GTK desktops more globally).
Well, I agree that some icons are a bit ugly, but that's part of upstream. Didn't they improve the battery icons recently? I think I've read something about this topic some weeks ago, but I didn't pay attention as I don't have any laptops with GNOME. It's ok to improve some stuff, but not too much imo, as it may alter upstream's design and add more work to do (= harder to maintain and keep up-to-date). But that's just my two cents :-) |
@gusbemacbe is there an oomox-plugin somewhere for these icons? |
Hello @DarthWound
@Bonandry would be happy with it. If some KDE users want me to include Breeze and KDE icons to Adwaita++ Minimal, maybe I will create another alternative icons theme – Adwaita++ Minimal KDE. But Adwaita++ Full is already efficient. Too many alternative icons themes. LOL
No, I did not do a plugin for Adwaita++ for Oomox. But I will do. I did not update my own Suru++ projects for months as I have said you before, because I was overly dedicated to Adwaita++ and Yaru++ projects @Bonandry broke. I already forbade him of messing the git and mixing and breaking them with old Suru++ Ubuntu. |
It makes sense for me.
Yeah I agree, just support KDE icons in Adwaita++ Full. But of course with GNOME design, like what varlesh did in his Breeze-Extra theme, he added icons for GNOME but respected the Plasma look.
🤣 I'm sorry lol, but I think you understand my point of view regarding a "minimal" variant. |
btw in themix forks of GNOME-Colors and Archdroid icons KDE icons are set as fallbacks: https://github.com/themix-project/gnome-colors-icon-theme/blob/master/gnome-colors/src/index.theme#L4 otherwise opening Dolphin or other kde app ends up with only half of icons on its toolbar |
@gusbemacbe Hello, I hope you're fine guys, as you're inactive since quite a long time now. |
Hello @DarthWound I and Andrea are fine. I am going to focus on Adwaita++. |
Hello @DarthWound and @actionless! There's a small problem. Adwaita does not contain colourful apps icons. Only symbolic and monochromatic icons, then it is very hard to remove the unnecessary icons to make Adwaita++ minimal. |
Hello guys, sorry I had a lot of work the last two weeks.
When I use vanilla GNOME, I like to stay with default Adwaita look'n'feel. The problem is that it lacks third-party apps icons, of course Adwaita++ solves that and it's great.
But imho it changes Adwaita a bit too much: places icons aren't the same, some actions/status symbols are missing or old or just different, some apps have an older style, etc...
To be honest it's why I don't use Adwaita++ anymore: too much different and sometimes outdated.
My suggestion is that you could ship another variant with ONLY icons for extra apps, inheriting default Adwaita in
index.theme
file. It would be much easier to maintain, and this way users still have an up-to-date icon theme that follows exactly the upstream, just with more apps included.Thank you 😅
The text was updated successfully, but these errors were encountered: