Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualRC: initial docs #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

VirtualRC: initial docs #86

wants to merge 3 commits into from

Conversation

chrismerck
Copy link
Contributor

Screen Shot 2023-04-05 at 10 03 22

image

image

@marciogranzotto
Copy link
Contributor

@chrismerck IDK if we can still do it, but talking with @endy-s and @RubensHardt, we felt that we should have two different properties: key: x for single-key events, keys: [x, y] for multi-key events.

@chrismerck
Copy link
Contributor Author

Old thread, but:

we should have two different properties

Hmm. Is that on the principle that a property value should have exactly one JSON type?

My resistance to keys was that that property is used in similar endpoint for "number of keys on this keypad".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubensHardt RubensHardt RubensHardt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrismerck @marciogranzotto @RubensHardt