Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to reflect autogen requirement #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md to reflect autogen requirement #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5485465
Update README.md to reflect autogen requirement
Wheest May 6, 2024
1936432
Added note about pkg-config requirement
Wheest May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ A Linux distribution. Pluto has been tested on x86 and x86-64 machines running
Fedora, Ubuntu, and CentOS.

- In order to use the development version from Pluto's git repository, automatic
build system tools, including `autoconf`, `automake`, and `libtool` are needed.
build system tools, including `autoconf`, `automake`, `pkg-config`, and `libtool`
are needed.

- LLVM/Clang 14.x (14.x recommended, 11.x, 12.x tested to work as well), along
with its development/header files, is needed for the pet submodule. These
Expand Down Expand Up @@ -59,8 +60,10 @@ pet's pre-requisites.
**Stable release:**

```shell
$ tar zxvf pluto-0.11.4.tar.gz
$ cd pluto-0.11.4/
$ PLUTO_VERSION=0.12.0
$ tar zxvf pluto-${PLUTO_VERSION}.tar.gz
$ cd pluto-${PLUTO_VERSION}/
$ ./autogen.sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release package shouldn't require a user to generate/regenerate the build config. The user shouldn't even ideally need to have autoconf/automake to build pluto from a release package (as opposed to the git repo). Please drop ./autogen.sh - not including that step was intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I pull the latest release (0.12.0), then the build config (a configure file that I can run with ./configure) isn't present. This is why I added the ./autogen.sh step.

wget https://github.com/bondhugula/pluto/releases/download/0.12.0/pluto-0.12.0.tar.gz
tar xfvz pluto-0.12.0.tar.gz 
cd pluto-0.12.0/

$ ./configure [--with-clang-prefix=<clang install location>]
$ make
$ make test
Expand Down