Explicity create and protect the background particle identity #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses #261
when there were no particles in the zeroth chunk, the background element was removed leading to an incorrect particle count (the background particle is always present in the LUT and counts with ID = 0).
|
Merge this PR before #263 |
alessandrofelder
approved these changes
Jun 15, 2020
mdoube
added a commit
that referenced
this pull request
Apr 5, 2024
* Don't remove IDs from chunkMaps with zero length * Fixes an NPE for images with some empty slices. * Explicitly create and protect the background particle ID 0 * Add a test for ConnectedComponents.getNParticles() Fixes #261 When there were no particles in the zeroth chunk, the background element was removed leading to an incorrect particle count (the background particle is always present in the LUT and counts with ID = 0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #261, which resulted from an implicit creation of the background particle ID (0) that was either not created, or created and then destroyed when there was no foreground particle in the zeroth image processing chunk.