Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete testImgs module #92

Merged
merged 6 commits into from
May 22, 2018
Merged

Delete testImgs module #92

merged 6 commits into from
May 22, 2018

Conversation

rimadoma
Copy link
Contributor

Deletes the largely redundant testImgs module. Modifies tests so that they're self contained, and don't require an additional module that just hangs around. Manual tests should be repeatable on an installation from the BoneJ update site, which excludes testImgs, because that module is not hosted there.

@alessandrofelder alessandrofelder self-assigned this May 22, 2018
@alessandrofelder alessandrofelder self-requested a review May 22, 2018 12:44
@alessandrofelder alessandrofelder removed their assignment May 22, 2018
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine - just the comment we discussed (hyperstacks in element fraction)

any());
}

// TODO Rewrite with a hyper stack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, a hyper-stack should probably report BV/TV for each channel at each time point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the review

@rimadoma rimadoma merged commit 900cee6 into master May 22, 2018
@rimadoma rimadoma deleted the delete-test-imgs branch May 23, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants