Skip to content

Commit

Permalink
chore!: drop Node.js v16
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Given a boatload of deps are dropping it, We have to drop it too.
  • Loading branch information
boneskull committed Dec 17, 2023
1 parent 8f7302e commit 1bc5a7e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 21 deletions.
20 changes: 4 additions & 16 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ on: [push, pull_request]

jobs:
build:
name: Test on node ${{ matrix.node_version }} and ${{ matrix.os }}
name: Node.js v${{ matrix.node_version }} / ${{ matrix.os }}
runs-on: ubuntu-latest
strategy:
matrix:
node_version: [16, 18, 20]
node_version: [18, 20]
os: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -17,7 +17,7 @@ jobs:
with:
node-version: ${{ matrix.node_version }}
- name: Upgrade npm
run: npm i -g npm@9 # upgrade to 'latest' when Node.js v16 is dropped
run: npm i -g npm
- name: Install dependencies
uses: bahmutov/npm-install@2509f13e8485d88340a789a3f7ca11aaac47c9fc # v1.8.36
with:
Expand All @@ -32,18 +32,6 @@ jobs:
- name: Install dependencies
uses: bahmutov/npm-install@2509f13e8485d88340a789a3f7ca11aaac47c9fc # v1.8.36
with:
install-command: npm ci --foreground-scripts
install-command: npm ci --ignore-scripts
- name: Lint
run: npm run lint
node16:
name: Check prod deps for Node.js v16
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
with:
node-version: 16
- name: Install dependencies
uses: bahmutov/npm-install@2509f13e8485d88340a789a3f7ca11aaac47c9fc # v1.8.36
with:
install-command: npm ci --foreground-scripts --omit=dev --engine-strict
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"packages/*"
],
"engines": {
"node": "^16.20.0 || ^18.0.0 || ^20.0.0",
"npm": ">=7"
"node": "^18.0.0 || ^20.0.0",
"npm": ">=8.6.0"
},
"scripts": {
"build": "tsc -b",
Expand Down
2 changes: 1 addition & 1 deletion packages/midnight-smoker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ A short--but profoundly incomplete--list of problems that typical tests don't ca

### Requirements

- Node.js versions supported: `^16.20.0 || ^18.0.0 || ^20.0.0`
- Node.js versions supported: `^18.0.0 || ^20.0.0`
- Minimum `npm` version supported (if using `npm`): `v7.0.0`
- Yarn should work, generally

Expand Down
4 changes: 2 additions & 2 deletions packages/midnight-smoker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"author": "Christopher Hiller <boneskull@boneskull.com> (https://boneskull.com/)",
"license": "Apache-2.0",
"engines": {
"node": "^16.20.0 || ^18.0.0 || ^20.0.0",
"npm": ">=7"
"node": "^18.0.0 || ^20.0.0",
"npm": ">=8.6.0"
},
"bin": {
"smoker": "./bin/smoker.js"
Expand Down

0 comments on commit 1bc5a7e

Please sign in to comment.