Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

severities not respected #333

Closed
boneskull opened this issue Aug 25, 2023 · 0 comments · Fixed by #336 or #342
Closed

severities not respected #333

boneskull opened this issue Aug 25, 2023 · 0 comments · Fixed by #336 or #342
Assignees
@boneskull
Labels
bug Something isn't working rules related to rules or linting

Comments

@boneskull
Copy link
Owner

Well, off is, but not warn. If a RuleFailure has severity: 'warn', then do not process.exitCode = 1.
@boneskull boneskull added bug Something isn't working rules related to rules or linting labels Aug 25, 2023
boneskull added a commit that referenced this issue Aug 27, 2023
@boneskull
chore: consolidate option parsing
87268dc 
BREAKING CHANGE: The `Smoker` class can no longer be instantiated directly; use `Smoker.init()`.  The `verbose` option will now cause a fatal error to throw its exception to the terminal. Rule configuration is now `severity string`, `rule-specific options`, or a tuple of `[rule-specifc options, severity string]`.  It can no longer be `[rule-specific options` nor `[severity string]`.  The config file schema has changed to reflect this.  Type `SmokeOptions` removed and is now the same type as `SmokerOptions`.

All options--wherever they come from--now go thru a single object schema.  This allows elimination some custom logic and duplicate types and provides better normalization.

Rules _must_ provide an options schema, even if that is just `ZodTypeObject`.  Rules may now provide default values for options; the `opts` parameter to a `RuleCheckFn` is now always defined and at minimum an empty object.

fix(checks): the "warn" severity is respected; closes #333
@boneskull boneskull mentioned this issue Aug 27, 2023
Merged
boneskull added a commit that referenced this issue Aug 27, 2023
@boneskull
chore: consolidate option parsing
738caa2 
BREAKING CHANGE: The `Smoker` class can no longer be instantiated directly; use `Smoker.init()`.  The `verbose` option will now cause a fatal error to throw its exception to the terminal. Rule configuration is now `severity string`, `rule-specific options`, or a tuple of `[rule-specifc options, severity string]`.  It can no longer be `[rule-specific options` nor `[severity string]`.  The config file schema has changed to reflect this.  Type `SmokeOptions` removed and is now the same type as `SmokerOptions`.

All options--wherever they come from--now go thru a single object schema.  This allows elimination some custom logic and duplicate types and provides better normalization.

Rules _must_ provide an options schema, even if that is just `ZodTypeObject`.  Rules may now provide default values for options; the `opts` parameter to a `RuleCheckFn` is now always defined and at minimum an empty object.

fix(checks): the "warn" severity is respected; closes #333
boneskull added a commit that referenced this issue Aug 27, 2023
@boneskull
chore: consolidate option parsing
6d15795 
BREAKING CHANGE: The `Smoker` class can no longer be instantiated directly; use `Smoker.init()`.  The `verbose` option will now cause a fatal error to throw its exception to the terminal. Rule configuration is now `severity string`, `rule-specific options`, or a tuple of `[rule-specifc options, severity string]`.  It can no longer be `[rule-specific options` nor `[severity string]`.  The config file schema has changed to reflect this.  Type `SmokeOptions` removed and is now the same type as `SmokerOptions`.

All options--wherever they come from--now go thru a single object schema.  This allows elimination some custom logic and duplicate types and provides better normalization.

Rules _must_ provide an options schema, even if that is just `ZodTypeObject`.  Rules may now provide default values for options; the `opts` parameter to a `RuleCheckFn` is now always defined and at minimum an empty object.

fix(checks): the "warn" severity is respected; closes #333
boneskull added a commit that referenced this issue Aug 27, 2023
@boneskull
chore: consolidate option parsing
af45bfe 
BREAKING CHANGE: The `Smoker` class can no longer be instantiated directly; use `Smoker.init()`.  The `verbose` option will now cause a fatal error to throw its exception to the terminal. Rule configuration is now `severity string`, `rule-specific options`, or a tuple of `[rule-specifc options, severity string]`.  It can no longer be `[rule-specific options` nor `[severity string]`.  The config file schema has changed to reflect this.  Type `SmokeOptions` removed and is now the same type as `SmokerOptions`.

All options--wherever they come from--now go thru a single object schema.  This allows elimination some custom logic and duplicate types and provides better normalization.

Rules _must_ provide an options schema, even if that is just `ZodTypeObject`.  Rules may now provide default values for options; the `opts` parameter to a `RuleCheckFn` is now always defined and at minimum an empty object.

fix(checks): the "warn" severity is respected; closes #333
boneskull added a commit that referenced this issue Aug 27, 2023
@boneskull
chore: consolidate option parsing
4e27a09 
BREAKING CHANGE: The `Smoker` class can no longer be instantiated directly; use `Smoker.init()`.  The `verbose` option will now cause a fatal error to throw its exception to the terminal. Rule configuration is now `severity string`, `rule-specific options`, or a tuple of `[rule-specifc options, severity string]`.  It can no longer be `[rule-specific options` nor `[severity string]`.  The config file schema has changed to reflect this.  Type `SmokeOptions` removed and is now the same type as `SmokerOptions`.

All options--wherever they come from--now go thru a single object schema.  This allows elimination some custom logic and duplicate types and provides better normalization.

Rules _must_ provide an options schema, even if that is just `ZodTypeObject`.  Rules may now provide default values for options; the `opts` parameter to a `RuleCheckFn` is now always defined and at minimum an empty object.

fix(checks): the "warn" severity is respected; closes #333
@boneskull boneskull self-assigned this Aug 27, 2023
boneskull added a commit that referenced this issue Aug 29, 2023
@boneskull
chore: consolidate option parsing
faf6a91 
BREAKING CHANGE: The `Smoker` class can no longer be instantiated directly; use `Smoker.init()`.  The `verbose` option will now cause a fatal error to throw its exception to the terminal. Rule configuration is now `severity string`, `rule-specific options`, or a tuple of `[rule-specifc options, severity string]`.  It can no longer be `[rule-specific options` nor `[severity string]`.  The config file schema has changed to reflect this.  Type `SmokeOptions` removed and is now the same type as `SmokerOptions`.

All options--wherever they come from--now go thru a single object schema.  This allows elimination some custom logic and duplicate types and provides better normalization.

Rules _must_ provide an options schema, even if that is just `ZodTypeObject`.  Rules may now provide default values for options; the `opts` parameter to a `RuleCheckFn` is now always defined and at minimum an empty object.

fix(checks): the "warn" severity is respected; closes #333
@github-actions github-actions bot mentioned this issue Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boneskull boneskull

Labels
bug Something isn't working rules related to rules or linting
Projects
None yet
Milestone
No milestone
1 participant
@boneskull