Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all hooks into surface components so they can be assembled/loaded automatically per-flavour #626

Closed
mayel opened this issue Jul 17, 2023 · 1 comment
Labels
Extensiblity / Modularity Features that enable bonfire to be extended and for modules to be disabled or swapped out Refactor Work that improves the understandability and quality of the code

Comments

@mayel
Copy link
Member

mayel commented Jul 17, 2023

eg.

export default {
  mounted(){
...
  }
}

and <div id="my_div" :hook>

or with multiple:

let PreviewActivity = {
...
}
let ClosePreview = {
...
}
export { PreviewActivity, ClosePreview }

and <div :hook="PreviewActivity">

Related to #707

@mayel mayel added the New Issue Please apply this label to any new issues :) label Jul 17, 2023
@mayel mayel added this to the v.0.9.11 - stretch goals milestone Jul 17, 2023
@mayel mayel added Refactor Work that improves the understandability and quality of the code and removed New Issue Please apply this label to any new issues :) labels Jul 17, 2023
@mayel mayel added the Extensiblity / Modularity Features that enable bonfire to be extended and for modules to be disabled or swapped out label Oct 14, 2023
mayel added a commit to bonfire-networks/bonfire_ui_social that referenced this issue Nov 3, 2023
mayel added a commit to bonfire-networks/bonfire_ui_common that referenced this issue Nov 3, 2023
@mayel mayel changed the title assemble the scripts in ui_common in one js file so that can be used by flavours withour repeating each other move all hooks into surface components so they can be assembled/loaded automatically per-flavour Nov 3, 2023
mayel added a commit to bonfire-networks/bonfire_ui_me that referenced this issue Dec 16, 2023
mayel added a commit to bonfire-networks/bonfire_classify that referenced this issue Dec 16, 2023
mayel added a commit to bonfire-networks/bonfire_editor_milkdown that referenced this issue Dec 16, 2023
mayel added a commit to bonfire-networks/bonfire_ui_kanban that referenced this issue Dec 16, 2023
mayel added a commit to bonfire-networks/bonfire_ui_social that referenced this issue Dec 16, 2023
mayel added a commit to bonfire-networks/bonfire_ui_common that referenced this issue Dec 16, 2023
@mayel
Copy link
Member Author

mayel commented Dec 16, 2023

done for all hooks in classic except for the generic copy and tooltip
still keeping per-flavour deps_hooks.js for now in case still needed (and because other flavours also have some hooks still using it)

note one workaround to have in mind: have to put paths to node_modules where JS deps may be found in ./assets/package.json like this NODE_PATH=./node_modules:../../../deps/bonfire_editor_milkdown/assets/node_modules

@mayel mayel closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extensiblity / Modularity Features that enable bonfire to be extended and for modules to be disabled or swapped out Refactor Work that improves the understandability and quality of the code
Projects
None yet
Development

No branches or pull requests

2 participants