-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LiveView possible optimisations #751
Labels
Performance
Work that improves the performance of bonfire
Milestone
Comments
ivanminutillo
added
New Issue
Please apply this label to any new issues :)
Bug
Performance
Work that improves the performance of bonfire
labels
Oct 27, 2023
ivanminutillo
added this to the 1.0 of core framework + Bonfire Classic + Bonfire Community milestone
Oct 27, 2023
we can benefit by separating css in surface components |
yeah and JS hooks as well, see #626 |
ivanminutillo
modified the milestones:
1.0 of core framework + Bonfire Classic + Bonfire Community,
LV optimisations
Oct 30, 2023
can we pass only object prop to the Bonfire.UI.Social.Activity.ActionsLive and Bonfire.UI.Social.Activity.NoteLive stateless components, avoiding passing the activity one ? |
ivanminutillo
added a commit
to bonfire-networks/bonfire_files
that referenced
this issue
Oct 30, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Oct 30, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_boundaries
that referenced
this issue
Oct 30, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_me
that referenced
this issue
Oct 30, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Oct 30, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 1, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Nov 1, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 2, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_boundaries
that referenced
this issue
Nov 2, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Nov 2, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 3, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_groups
that referenced
this issue
Nov 3, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Nov 3, 2023
mayel
added a commit
to bonfire-networks/bonfire_gatherings
that referenced
this issue
Nov 3, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_groups
that referenced
this issue
Nov 3, 2023
mayel
added a commit
to bonfire-networks/bonfire_editor_quill
that referenced
this issue
Nov 3, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_me
that referenced
this issue
Nov 3, 2023
mayel
added a commit
to bonfire-networks/bonfire_editor_ck
that referenced
this issue
Nov 3, 2023
ivanminutillo
added a commit
to bonfire-networks/bonfire_search
that referenced
this issue
Nov 8, 2023
mayel
added a commit
that referenced
this issue
Nov 9, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_me
that referenced
this issue
Nov 9, 2023
mayel
added a commit
to bonfire-networks/bonfire_boundaries
that referenced
this issue
Nov 9, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 9, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Nov 9, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 9, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Nov 9, 2023
mayel
added a commit
that referenced
this issue
Nov 15, 2023
mayel
added a commit
to bonfire-networks/bonfire_boundaries
that referenced
this issue
Nov 15, 2023
mayel
added a commit
to bonfire-networks/bonfire_social
that referenced
this issue
Nov 15, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 15, 2023
mayel
added a commit
to bonfire-networks/bonfire_social
that referenced
this issue
Nov 18, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 18, 2023
mayel
added a commit
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_groups
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_me
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_classify
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_breadpub
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_topics
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_boundaries
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_coordination
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_valueflows
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_social
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_pages
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_ui_common
that referenced
this issue
Nov 21, 2023
mayel
added a commit
to bonfire-networks/bonfire_upcycle
that referenced
this issue
Jan 20, 2024
mayel
added a commit
to bonfire-networks/bonfire_upcycle
that referenced
this issue
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based upon Marlus Saraiva talk https://www.youtube.com/watch?v=kBU4v609DOU
Minimize dynamic parts
<button disabled={@disabled} class={my_class(@disabled)}>increment</button>
in this case the server will receive all the css classes that returns with the my_class fn. So instead of using the function and inject dynamic code directly in the template, we can use data/aria/state selector (that will remain the only dynamic part ) and add code on the css file (which is passed only 1time on mount) like:button class="btn" disabled={@disabled}>increment</button>
and on the css file :.btn {...} .btn[disabled] {...}
or can use tailwind variants such<div class="disabled:bg-red-500 ...">
<- this trick can save a lot especially since we're using tailwind!instead of:
do this:
<div data-kind={@kind} class="toast">....</div>
and in the css.toast {...} .toast[data-kind="warning"] {...} .toast[data-kind="error"]{...}
or can use tailwind custom variants such<div class="data-[kind=error]:bg-red-500 ...">
or using tailwindgroup
operator to style several elements based on a variable set in a single parentMinimize re-rendering
Bonfire.Boundaries.LiveHandler.my_acls/1
<Profile user={@user} />
-><Profile first_name={@user.first_name} last_name={@user.last_name} />
Minimize server/client communication (<-- this seems also crucial for bonfire)
:erlang.statistics(:run_queue)
to see if VM schedulers are too busy when messages start to piled up, this can happen even when CPU’s utilization (and load average) stays consistently low.Other
The text was updated successfully, but these errors were encountered: