Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a DB view on top of Replied that sums the two reply counts for use instead of fragments in sorting/pagination #639

Closed
mayel opened this issue Aug 2, 2023 · 2 comments
Closed

Create a DB view on top of Replied that sums the two reply counts for use instead of fragments in sorting/pagination #639

mayel opened this issue Aug 2, 2023 · 2 comments
Labels
Refactor Work that improves the understandability and quality of the code
Milestone
0.9.07 - feeds

Comments

@mayel
Copy link
Member

mayel commented Aug 2, 2023

No description provided.

@mayel mayel added this to the v0.9.7 - feeds milestone Aug 2, 2023
@mayel mayel mentioned this issue Aug 2, 2023
Closed
3 tasks
@mayel mayel added the Refactor Work that improves the understandability and quality of the code label Aug 14, 2023
mayel added a commit to bonfire-networks/bonfire_data_social that referenced this issue Aug 22, 2023
@mayel
https://github.com/bonfire-networks/bonfire-app/issues/639
2b7e3ff
mayel added a commit that referenced this issue Aug 22, 2023
@mayel
https://github.com/bonfire-networks/bonfire-app/issues/639
01e555a
mayel added a commit that referenced this issue Aug 23, 2023
@mayel
WIP fix for #639
cdbc3e3
mayel added a commit to bonfire-networks/bonfire_data_social that referenced this issue Aug 23, 2023
@mayel
WIP fix for bonfire-networks/bonfire-app#639
4ef8e46
mayel added a commit to bonfire-networks/bonfire_social that referenced this issue Aug 23, 2023
@mayel
WIP fix for bonfire-networks/bonfire-app#639
8797b31
@mayel mayel reopened this Aug 23, 2023
@mayel
Copy link
Member Author

mayel commented Aug 23, 2023 •
edited

reopened because ecto doesn't support generated/read only field, either says (Ecto.QueryError) : field total_replies_countinwhere is a virtual field in schema if you make it a virtual field, or tries to insert into that field if you do put_assoc

mayel added a commit that referenced this issue Aug 23, 2023
@mayel
https://github.com/bonfire-networks/bonfire-app/issues/639
33f2140
mayel added a commit to bonfire-networks/bonfire_data_social that referenced this issue Aug 23, 2023
@mayel
Revert "WIP fix for bonfire-networks/bonfire-app#639"
024c271 
This reverts commit 4ef8e46.
mayel added a commit to bonfire-networks/bonfire_data_social that referenced this issue Aug 23, 2023
@mayel
https://github.com/bonfire-networks/bonfire-app/issues/639
0dbb03e
mayel added a commit to bonfire-networks/bonfire_social that referenced this issue Aug 23, 2023
@mayel
Revert "WIP fix for bonfire-networks/bonfire-app#639"
9235c66 
This reverts commit 8797b31.
mayel added a commit to bonfire-networks/bonfire_social that referenced this issue Aug 23, 2023
@mayel
https://github.com/bonfire-networks/bonfire-app/issues/639
7d2e2e5
@mayel
Copy link
Member Author

mayel commented Aug 23, 2023

scratch that, seems that's only the case if you have a default value on the field

@mayel mayel closed this as completed Aug 23, 2023
mayel added a commit to bonfire-networks/bonfire_ui_social that referenced this issue Aug 23, 2023
@mayel
https://github.com/bonfire-networks/bonfire-app/issues/639
f1d5b52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Work that improves the understandability and quality of the code
Projects
None yet
Milestone
0.9.07 - feeds
Development

No branches or pull requests
1 participant
@mayel