Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter components from hide-component attribues #215

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

benjaminParisel
Copy link
Contributor

@benjaminParisel benjaminParisel commented Apr 2, 2024

  • Create a new helper to filter components array
  • Adding an example page in preview site

closes #214

* Create a new helper to filter components array
* Adding an example page in preview site
Copy link

github-actions bot commented Apr 2, 2024

♻️ PR Preview 0181614 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

* site.component is an object on the antora 3 side but an array on this preview-src side
@benjaminParisel benjaminParisel added enhancement New feature or request showroom labels Apr 2, 2024
Co-authored-by: Romain Bioteau <romain.bioteau@bonitasoft.com>
@tbouffard tbouffard changed the title feat: Filter components from hide-component attribues feat: filter components from hide-component attribues Apr 3, 2024
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Tested with the surge preview environment
✔️ Tested locally in the context of the documentation site (configuration in the component version descriptor): bonitasoft/bonita-documentation-site#691 (comment)

src/partials/header-content.hbs Outdated Show resolved Hide resolved
src/partials/header-content.hbs Outdated Show resolved Hide resolved
Co-authored-by: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com>
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@benjaminParisel benjaminParisel merged commit 97f6001 into master Apr 3, 2024
3 checks passed
@benjaminParisel benjaminParisel deleted the feat/hide_component branch April 3, 2024 08:26
benjaminParisel pushed a commit to bonitasoft/bonita-documentation-site that referenced this pull request Apr 3, 2024
Validate that the components can be hidden in navbar and in the
component/version selector in all pages of a given component version.
This is done with a configuration in the component version descriptor.

Covers #689
Depends on
bonitasoft/bonita-documentation-theme#215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request showroom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide component from header and nav-bar when 'page page-hide-components' is set
3 participants