Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Add ModalDownsampler #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

superdump
Copy link
Contributor

Something like this I think. In the test I was trying to use 1x1x1 lod0 chunks and a 2x2x2 superchunk and lod0 extent, thinking that it would downsample the 2x2x2 extent of lod0 to a 1x1x1 lod1, but I hit the assertion on the dst shape being Point3i::ZERO. I don't understand why.

@superdump
Copy link
Contributor Author

I've tried it for my blocky voxel terrain stuff and it's really slow. Perhaps it's useful for someone?

@bonsairobo
Copy link
Owner

Maybe you could add a benchmark in building_blocks_storage/benches/sampling.rs so we can compare actual numbers?

I also suspect that using the SmallKeyHashMap would help. It would be even better if we could assume that the voxel type was an index into an array.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants