Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown date for 'seen' entry should be null, not 0 #269

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

bonukai
Copy link
Owner

@bonukai bonukai commented Apr 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #269 (111bece) into main (562e4dd) will increase coverage by 1.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   60.90%   62.01%   +1.11%     
==========================================
  Files         101      102       +1     
  Lines        2995     2996       +1     
  Branches      317      317              
==========================================
+ Hits         1824     1858      +34     
+ Misses        921      899      -22     
+ Partials      250      239      -11     
Impacted Files Coverage Δ
server/src/controllers/seen.ts 46.15% <0.00%> (+41.02%) ⬆️
...er/src/migrations/20220404141200_seenDateToNull.ts 100.00% <100.00%> (ø)
server/src/repository/repository.ts 72.50% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562e4dd...111bece. Read the comment docs.

@bonukai bonukai merged commit 0949cca into main Apr 4, 2022
@bonukai bonukai deleted the seenDateToNull branch April 4, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant