This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Refactor SDK with webpack 4 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # package.json
LICENSE
Outdated
|
|
||
| Copyright (c) 2017 Fabien | ||
| Copyright (c) 2018 SteemConnect.js |
There was a problem hiding this comment.
Changing a license technically requires that all contributors sign off - or have signed a retroactive CLA. In this case you are merely changing the name of the copyright holder - however if SteemConnect.js is not a legal entity then you are technically "disowning" or "orphaning" the project.
There was a problem hiding this comment.
Furthermore, you should also change this line in your package.json:
"author": "Bonustrack fabien@bonustrack.co (https://github.com/bonustrack)"
Sekhmet
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Published on NPM as
sc2-sdk@2.0.0-beta.0sc2-sdk@2.0.0-beta.1