The git var GIT_EDITOR fatal behaviour was likely never important

[adelton]

The fatal behaviour was removed from v2.39.0-rc0-2-g2ad150e35e via git/git@2ad150e so it was likely never important.

[adelton]

The change of git behaviour caused Fedora package builds to fail: https://bugzilla.redhat.com/show_bug.cgi?id=2175807.

This patch was included in build https://koji.fedoraproject.org/koji/taskinfo?taskID=98452851 which passed.

[gregoa]

An alternative to removing the tests might be to skip them conditionally:

--- a/t/20-simple.t
+++ b/t/20-simple.t
@@ -85,6 +85,9 @@
     skip "this test does not work with msysgit on Win32", 2
         if $^O eq 'MSWin32';
 
+    skip "'git var GIT_EDITOR' behaviour was changed in git 2.40.0, and we have $version", 2
+        if Git::Repository->version_ge('2.40.0');
+
     ok( !eval { $r->run( var => 'GIT_EDITOR' ); 1; }, 'git var GIT_EDITOR' );
     like(
         $@,

Cheers,
gregor,
Debian Perl Group (where we see the same issue)