feat: うごイラのサポート #211
Merged
feat: うごイラのサポート #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
book000
approved these changes
Nov 16, 2023
|
@hker9527 まずはこのプロジェクトを見つけていただき、そして、プルリクエストを送っていただきありがとうございます❤️ CI (Continuous Integration)に問題がありそうなので、一度別のブランチにマージしてからmasterブランチにマージします。少々お待ちください！ First of all, thank you for finding this project and sending us a pull request❤️ There seems to be a problem with CI (Continuous Integration), so I will merge it once into another branch and then into the master branch. Please wait a moment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
こんにちは。
pixiv.ts（もう一つのTypeScriptピクシブライブラリ）のアップデートが進んでないまま、TypeScriptで使えるpixivライブラリをGoogle検索で探したら、こちらのレポジトリを見つけました。素敵なライブラリを提供して頂いてありがとうございました。
私のDiscord Botには、うごイラをプロセスする機能があるのですが、こちらのライブラリはうごイラの機能はまだインプリメンテーションがないみたいなので、失礼ですが勝手に書いてみました。変なところがあれば、教えていただければ幸いです。
（母語は日本語ではありませんので、下に英語版も載せていただきます。）
Hello!
As pixiv.ts, which is the current library my Discord bot is using, has not been updated for a while now. I have stumbled upon this repo when searching for an active TypeScript repository, but it seems that this library does not support Ugoira endpoints, so I tried to implement it. I am not familiar with JSDoc but I referenced some of your code to mimic one. Please tell me suggestions to improve the code!
Thank you for providing a free library to share among all programmers on the world!