Remove unnecessary call of _.snakeCase on a literal #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
LordSputnik
requested changes
Mar 8, 2018
There was a problem hiding this comment.
Looks like a good improvement - please just change the format of the commit message as described in #184
Remove use of _.snakeCase() on `editorId` and use `editor_id` directly. Fixes metabrainz#243 BREAKING CHANGE: To avoid unnecessarily call of lodash , use of _.snakeCase() on editorId has removed and used `editor_id` directly.
|
@LordSputnik thanks for the review. I have updated the commit message as suggested. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is use of _.snakeCase on literal(editorId).
Solution
Remove use of _.snakeCase and use editor_id directly.
Areas of Impact
src/server/helpers/achievement.js
src/server/routes/editor.js