Update last login time in database to fix issue #BB-311 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r editor/user data at the time of login.
…profile same as MusicBrainz.
MonkeyDo
requested changes
Jan 17, 2019
src/server/routes/auth.js
Outdated
| @@ -46,6 +46,13 @@ router.get('/cb', (req, res, next) => { | |||
| return next(loginErr); | |||
| } | |||
|
|
|||
| const {Editor} = req.app.locals.orm; | |||
| const lastLoginDate = new Date().toISOString(); | |||
| (() => { | |||
There was a problem hiding this comment.
I'm not sure how much I like self-invoking functions. I find they are confusing, especially for a beginner reading the code for the first time.
I would suggest to make the callback passed to .logIn asynchronous, and awaiting the Editor function calls.
In pseudo code, just to make sure I am clear:
return req.logIn(user, async (loginErr) => {
[...]
await Editor.where(XYZ).save(XYZ);
[...]
return res.redirect(redirectTo);
}
|
Thankyou @MonkeyDo for review, |
MonkeyDo
requested changes
Jan 17, 2019
|
Great, thanks @akhilesh26, I'm glad to see this fixed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The timestamp is same for Joined and Last Active in user's detail.
Solution
The database is updated for last login time.
Update label Last Active to Last login same as MusicBrainz.
Areas of Impact
Client-side:
src/client/components/pages/parts/editor-profile.jsServer-side:
src/server/routes/auth.js