Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scrollbar in the 'add to collection' modal #558

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

dipscoder
Copy link
Contributor

Problem

https://tickets.metabrainz.org/projects/BB/issues/BB-582?filter=allopenissues

Solution

Add a scrollbar to prevent the content from overflowing and to give a better user experience.
Here are the Screenshots,

Before,
Screenshot (246)

After,
Screenshot (245)

Areas of Impact

src/client/stylesheets/style.less

@welcome
Copy link

welcome bot commented Feb 28, 2021

Thanks for opening your first pull request for BookBrainz, and welcome to our community! 🎉

If you haven't yet, please check out our contributing guidelines.

Someone will be reviewing your PR soon; just hang in there !
In the meantime, if you're wondering what to do next, you can have a look at our issue tracker

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.922% when pulling f77820f on dipscoder:Fix/Issue-582 into 613b76a on bookbrainz:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.922% when pulling f77820f on dipscoder:Fix/Issue-582 into 613b76a on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thank you for this improvement!

@MonkeyDo MonkeyDo merged commit f536747 into metabrainz:master Mar 8, 2021
@welcome
Copy link

welcome bot commented Mar 8, 2021

Congratulations on your first merged pull request for BookBrainz! 🎉
We're very thankful for your work, and happy to count you part of our team !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants