Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user import #487

Merged
merged 1 commit into from Jul 12, 2014
Merged

Update user import #487

merged 1 commit into from Jul 12, 2014

Conversation

sambuddhabasu
Copy link
Member

No description provided.

@sambuddhabasu sambuddhabasu changed the title Upgrade user import Update user import Jul 9, 2014
@bookiebot
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/139/

@bookiebot
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/202/

@bookiebot
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/178/

@mitechie
Copy link
Member

👍 Thanks for the update.

@bookiebot
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/140/

@bookiebot
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/203/

@bookiebot
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/179/

craigmaloney
craigmaloney reviewed Jul 12, 2014
View reviewed changes
bookie/lib/importer.py
if link.has_key('PRIVATE'): # noqa
continue
is_private = False
if link.has_key('private'): # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should do a search in the keys to cover "private", "is_private" or any other version of this.

That said, maybe that's more trouble than its worth.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For DelImporter, the private bookmarks are marked with a 'PRIVATE="1"', so we are searching here with key 'private'.

@craigmaloney
Copy link
Contributor

👍

@sambuddhabasu
Upgrade user import
bdd9d15 
Updated tests for user import
@bookiebot
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/141/

@bookiebot
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/204/

@bookiebot
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/180/

@sambuddhabasu
Copy link
Member Author

:shipit:

@bookiebot
Copy link
Contributor

Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander

bookiebot added a commit that referenced this pull request Jul 12, 2014
@bookiebot
Merge pull request #487 from sammyshj/updateimport
8d96915 
Update user import
@bookiebot bookiebot merged commit 8d96915 into bookieio:develop Jul 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sambuddhabasu @bookiebot @mitechie @craigmaloney