Dockerfiles: add CA certs, remove PATH truncation

Forcing PATH like that makes the container feel very odd if you exec into it. CA certs are nice if you want to download Helm charts over SSL.
bookingcom · Dec 10, 2018 · 487912c · 487912c
1 parent 46e93cc
commit 487912c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Dockerfile.metrics b/Dockerfile.metrics
@@ -1,5 +1,6 @@
 ARG BASE_IMAGE=alpine:3.8
 FROM ${BASE_IMAGE}
 LABEL authors="Parham Doustdar <parham.doustdar@booking.com>, Alexey Surikov <alexey.surikov@booking.com>, Igor Sutton <igor.sutton@booking.com>, Ben Tyler <benjamin.tyler@booking.com>"
+RUN apk add ca-certificates
 ADD shipper-state-metrics /bin/shipper-state-metrics
 ENTRYPOINT ["shipper-state-metrics", "-v", "2"]
diff --git a/Dockerfile.shipper b/Dockerfile.shipper
@@ -1,6 +1,6 @@
 ARG BASE_IMAGE=alpine:3.8
 FROM ${BASE_IMAGE}
 LABEL authors="Parham Doustdar <parham.doustdar@booking.com>, Alexey Surikov <alexey.surikov@booking.com>, Igor Sutton <igor.sutton@booking.com>, Ben Tyler <benjamin.tyler@booking.com>"
+RUN apk add ca-certificates
 ADD shipper /bin/shipper
-ENV PATH=/bin
 ENTRYPOINT ["shipper", "-disable", "clustersecret", "-v", "4", "-logtostderr"]