This repository has been archived by the owner on May 3, 2022. It is now read-only.
Installation controller fails to create when a namespace is terminating #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hihilla
changed the title
…ng or deleted This change makes the kubeclient error with cause `Namespace Terminating`, or a forbidden (404) error with kind `namespaces` (namespace not found error) retryable
hihilla
force-pushed
the
hilla/CRUNTIME-692
branch
from
f3eacca
to
63a014f
Compare
hihilla
changed the title
ArchangelX360
previously approved these changes
May 12, 2021
nikoloup
reviewed
May 12, 2021
| Namespace manager | ||
| ***************** | ||
| By design, Shipper does not create namespaces in the application cluster. | ||
| In case the namespace does not exist in the application cluster, and this application cluster is selected for a *Release*, |
There was a problem hiding this comment.
Should we specify here just for completeness that the expected namespace in the application cluster has to be of the same name?
nikoloup
previously approved these changes
May 12, 2021
hihilla
force-pushed
the
hilla/CRUNTIME-692
branch
from
63a014f
to
f93b46c
Compare
nikoloup
approved these changes
May 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the kubeclient error with cause
Namespace Terminating, or a forbidden (404) error with kindnamespaces(namespace not found error) retryable