Supply Date.now()

[mborst]

I maintain an app that uses a software supplied timestamp for all timestamp fields in the database, among them the create and update timestamps.

Doing this while still using the hasTimestamp magic requires patching this line to use options[...] instead of new Date().

I could provide a PR if that seems like a useful feature to have in bookshelf.

[kirrg001]

@mborst You can use the format fn to modify the dates before they are written into the database.

[mborst]

Thanks! But I think using format here is kind of sub-optimal. Seems very unintuitive to really modify the data there. Plus how would I pass in the date into format?
For now I have written a plugin that patches hasTimestamp in the suggested way, which makes the most sense imho. Or do you disagree with the general idea of this suggestion?

[kirrg001]

The options object is usually used for very general options e.g. transaction, method.
That's why i am not sure your suggestion fits good. The plugin you have written is also a good choice 👍 Otherwise the format function can be used to transform the created_at/updated_at into the format you need.

[mborst]

It's not about formatting it, I would really change it! Plus, I would also need to pass the timestamp I want to use into format, which would be a far bigger change.
To maybe make what I want to achieve more clear:
bsiddiqui/bookshelf-paranoia#21

[Playrom]

maybe this has been fixed with #1583 , is it the same problems, am I correct?

[mborst]

Halfway. I also want to use it for the updated_at timestamp. That's why I wrote a plugin that applies the patch mentioned above (picking the user supplied date from options). That way, I can use the same interface as the paranoia plugin allows (see here)

[Playrom]

ok!

can you provide a PR in the same style as #1583 but for the update_at timestamp?

I will merge it to the master :)

[mborst]

Ok, so this would be the PR: #1592. If you agree with it in principle, I could provide tests and documentation.

[Playrom]

closing here, discuss in #1592