New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Model fetchAll event documentation #1114

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
3 participants
@mikeharty
Contributor

mikeharty commented Jan 29, 2016

The fetching:collection and fetched:collection event tags have the event name wrapped in quotes. This is causing an issue in JSDoc which is preventing these events from being rendered in the menu and in the event detail blocks. This fixes that by removing the quotes and updating the JSDoc theme to use a more accurate regular expression for simplifying event names (bookshelf/bookshelf-jsdoc-theme#3).

@rhys-vdw

This comment has been minimized.

Contributor

rhys-vdw commented May 11, 2016

Hey, I added a comment over at bookshelf/bookshelf-jsdoc-theme#3. Sorry for the late response.

@rhys-vdw rhys-vdw added the discussion label May 11, 2016

@ricardograca ricardograca added docs and removed discussion labels Jan 5, 2018

@ricardograca

This comment has been minimized.

Member

ricardograca commented Jan 5, 2018

I'm going to merge this because even with the default JSDoc theme the quotes break things. This change will require a new version of our own jsdoc theme.

@ricardograca ricardograca merged commit 6576f41 into bookshelf:master Jan 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment