Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide client (sqlite3) as required by knex 0.12.7 #1531

Merged
merged 1 commit into from Jun 29, 2017
Merged

Provide client (sqlite3) as required by knex 0.12.7 #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/index.js
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ describe('Bookshelf', function () {
it('VERSION should equal version number in package.json',
function () {
var Knex = require('knex');
var bookshelf = Bookshelf(Knex({}));
var bookshelf = Bookshelf(Knex({client: 'sqlite3'}));
var p = require('../package.json');
expect(p.version).to.equal(bookshelf.VERSION);
});
Expand Down
4 changes: 2 additions & 2 deletions test/integration.js
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ module.exports = function(Bookshelf) {
var MySQL = require('../bookshelf')(mysql);
var PostgreSQL = require('../bookshelf')(pg);
var SQLite3 = require('../bookshelf')(sqlite3);
var Swapped = require('../bookshelf')(Knex({}));
var Swapped = require('../bookshelf')(Knex({client: 'sqlite3'}));
Swapped.knex = sqlite3;

it('should allow creating a new Bookshelf instance with "new"', function() {
Expand All @@ -32,7 +32,7 @@ module.exports = function(Bookshelf) {
});

it('should allow swapping in another knex instance', function() {
var bookshelf = new Bookshelf(Knex({}));
var bookshelf = new Bookshelf(Knex({client: 'sqlite3'}));
var Models = require('./integration/helpers/objects')(bookshelf).Models;
var site = new Models.Site();

Expand Down