Undeprecate options.date argument to timestamp #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardograca
requested changes
Apr 24, 2018
src/base/model.js
Outdated
| @@ -633,6 +633,9 @@ ModelBase.prototype.getTimestampKeys = function() { | |||
| * @param {string} [options.method] | |||
| * Either `'insert'` or `'update'` to specify what kind of save the attribute | |||
| * update is for. | |||
| * @param {string} [options.date] | |||
| * Either a Date object or ms since the epoch. Specify what date is used for | |||
| * the timestamps updated. | |||
There was a problem hiding this comment.
Can you change this a little bit to make it clearer what the purpose of date is? Something like:
Specify what date is used as the value of
nowwhen creating or updating timestamp attributes. This overrides the current date with the specified value.
|
Updated. |
ricardograca
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
options.datehas been deprecated in #1798. This PR reverts this.Motivation
See discussion at the end of #1798
Proposed solution
Revert the deprecation.