Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching editions changes "shelved" date #3139

Closed
dnoesgaard opened this issue Nov 28, 2023 · 0 comments · Fixed by #3193
Closed

Switching editions changes "shelved" date #3139

dnoesgaard opened this issue Nov 28, 2023 · 0 comments · Fixed by #3193
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dnoesgaard
Copy link

Describe the bug
When switching editions of a book already on your "To Read" list, the "shelved" date is changed to today's date.

To Reproduce
Steps to reproduce the behavior:

  1. Pick any book on your "To read" list with more than one edition
  2. Pick another edition and switch to this
  3. Observe that the book's shelved date is now today

Expected behavior
This shouldn't changed the shelved date

Instance
https://books.theunseen.city

Desktop (please complete the following information):
- OS: MacOS 14.1
- Browser: Firefox
- Version: 20.0 (64-bit)
@dnoesgaard dnoesgaard added the bug Something isn't working label Nov 28, 2023
@mouse-reeve mouse-reeve added the good first issue Good for newcomers label Dec 3, 2023
@jakejack13 jakejack13 mentioned this issue Jan 4, 2024
Merged
@dato dato closed this as completed in #3193 Mar 3, 2024
dato added a commit that referenced this issue Mar 3, 2024
@dato
Fix shelving date changing when changing editions (#3193)
9e7b040 
Merged from  from jakejack13/switch-edition
Fixes: #3139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed shelving date changing when changing editions jakejack13/bookwyrm
2 participants
@mouse-reeve @dnoesgaard