Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable defaults for incomplete parsed dates #3038

Merged
merged 4 commits into from Oct 17, 2023

Conversation

dato
Copy link
Contributor

@dato dato commented Oct 16, 2023

  • 8f0f3e6 ImportItem: preserve parsed timezones in date_started, date_read
  • c066d11 Bugfix: default missing date components to 1, not today's
  • c02306a Default to Jan 1st too on incomplete dates received from ActivityPub
  • 8afcb9b Fix tests warning: ImportJob.updated_date received a naive datetime

Fixes: #2660.

This is a follow-up to b564e51 ("Handle parsed dates that already
have a timezone on import"), which was applied to `date_added` only.

(Appart from consistency, this will allow to apply future parsing fixes
more easily.)
@jaschaurbach
Copy link
Member

woah thank you! This is great!

@jaschaurbach jaschaurbach merged commit 3ade72b into bookwyrm-social:main Oct 17, 2023
10 checks passed
@dato dato deleted the parsed_date_defaults branch October 20, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing book uses today's values for missing date parts
2 participants