Move ratings and reviews when switching editions #3117
Conversation
There was a problem hiding this comment.
This is my first contribution to Bookwyrm and, more importantly, my first time looking at Django and pytest. I am not (yet) a python person.
Welcome! And thanks for contributing. I'm a fairly new contributor myself, and interacting with the community has been a pleasure so far. <3
The code and tests are pretty simple but something is not making sense.
Ah, I cloned your PR and then followed your steps... (behaved as you described), then started reading about the models a bit and noticed...
However, if I remove the new code for ratings or just the
rating.book = new_editionline, the new test for ratings still passes. I feel crazy.
... I believe this weird behavior could be accounted for by the fact that ReviewRating inherits from Review, and hence the loop over Review.objects would cover ReviewRating as well?
ReviewRatings are a subclass and are included in the models.Review block
…n-switching-editions
…thub.com:mattlehrer/bookwyrm into move-ratings-and-reviews-when-switching-editions
|
I fixed the lint problems, sorry! |
Fixes #2926
This is my first contribution to Bookwyrm and, more importantly, my first time looking at Django and pytest. I am not (yet) a python person. The code and tests are pretty simple but something is not making sense.
Most importantly, the ratings and reviews do move to the new edition in manual testing. If I comment out the for loop or just the line
readthrough.book = new_editionthen the associated test fails. Same forreview.book = new_editionand my new test for reviews. All good so far. However, if I remove the new code for ratings or just therating.book = new_editionline, the new test for ratings still passes. I feel crazy.I hope this is at least a step in the right direction. Thanks!