Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bulk_create to test ordered collections #3143

Conversation

dato
Copy link
Contributor

@dato dato commented Nov 30, 2023


Before:

❯ pytest -q --durations=2 bookwyrm/tests/models/test_activitypub_mixin.py -k ordered
3.47s call     ActivitypubMixins::test_to_ordered_collection
3.91s call     ActivitypubMixins::test_to_ordered_collection_page
2 passed, 19 deselected in 8.00s

After:

❯ pytest -q --durations=2 bookwyrm/tests/models/test_activitypub_mixin.py -k ordered
1.39s call     ActivitypubMixins::test_to_ordered_collection
2.03s call     ActivitypubMixins::test_to_ordered_collection_page
2 passed, 19 deselected in 4.04s

@mouse-reeve mouse-reeve merged commit e5d2929 into bookwyrm-social:main Dec 9, 2023
10 checks passed
@dato dato deleted the test_ordered_collection_use_bulk_create branch December 11, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants