bulk-fmt: bracket-wrap calls to patch() for better readability #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dato
force-pushed
the
better-fmt-patch-calls
branch
from
837bce5
to
90bd893
Compare
|
This looks a lot better! Is this PR intentionally still a draft? |
I wasn't sure if it'd create conflicts with any ongoing review, so I erred on the safe side to give lower-numbered PRs a chance to go in. |
Conflicts: bookwyrm/tests/test_book_search.py
Minnozz
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I wanted to fix is in the first commit. I just took the opportunity to also pay the
bad-classmethod-argumentdebt I introduced a while ago.