black: specify major version 22 only #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures consistent formatting among different contributors / development setups. https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#required-version
This way, IDEs can be set up to use the black version from the environment instead of a globally available/bundled black version.
|
I'm not well-versed enough with Python development setups to know if the last point (adding black as a dependency) is acceptable. Input is welcome! |
dato
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
I'm not well-versed enough with Python development setups to know if the last point (adding black as a dependency) is acceptable. Input is welcome!
Sounds acceptable to me, we just need to drop it in the merge to the production branch (i.e. when resolving conflicts there).
Cool! (I wasn't aware a production branch existed until now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes some places where black (the Python formatter) is referenced:
stable(as recommended)22.*(formatting is guaranteed to be stable within a major version)pyproject.tomlto avoid formatting with a different major version. This improves consistency between different contributors (eg, me) having different black versions set up in their IDE