Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS path prefix when S3 storage is used #3384

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fix CSS path prefix when S3 storage is used #3384

merged 1 commit into from
Jul 14, 2024

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Jun 12, 2024

Are you finished?

Linters

  • I have checked my code with black, pylint, and mypy, or ./bw-dev formatters

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Description

django-sass-processor 1.4 looks up OPTIONS using sass_processor instead of staticfiles.
Add sass_processor field to STORAGES config, in order to let django-sass-processor 1.4 look up the OPTIONS.
This change will fix CSS path to have /static prefix.

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

@lo48576
Fix CSS path prefix when S3 storage is used
1a2f434 
django-sass-processor 1.4 looks up OPTIONS using `sass_processor`
instead of `staticfiles`.

Fixes bookwyrm-social#3383.
@lo48576 lo48576 mentioned this pull request Jun 12, 2024
Closed
Minnozz
Minnozz approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@Minnozz Minnozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for investigating and fixing this issue!

@Minnozz Minnozz merged commit ab30738 into bookwyrm-social:main Jul 14, 2024
10 checks passed
@lo48576 lo48576 deleted the fix/css-path-prefix-with-s3-backend branch July 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minnozz Minnozz Minnozz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong CSS paths with S3 object storage (while non-CSS assets paths are correct)
2 participants
@lo48576 @Minnozz