ISBN search #697
Merged
ISBN search #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! I can't find anything to quibble about, thanks for your thorough work and tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposition to fix the #467 issue and to allow other connectors beyond OpenLibray to have a custom ISBN search method.
The global search now try first a ISBN search if the query looks like a isbn10 or isbn13, and fallback to regular search if no result is found.
For this I made a new migration which creates a 'isbn_search_url' field in the Connector table, and I've updated the initdb.py script with the values for OpenLibrary and Bookwyrm instances.