Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache invalidation index #17

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Add cache invalidation index #17

merged 3 commits into from
Dec 26, 2023

Conversation

vearutop
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 26, 2023

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 37 2252 (+37) 1640 (+28) 171 (+2) 441 (+7) 267 (+1) 55.5K (+1K)
YAML 6 488 (+3) 402 (+3) 36 50 0 16.1K (+147B)

Copy link

github-actions bot commented Dec 26, 2023

Go API Changes

# github.com/bool64/brick
## incompatible changes
BaseLocator.CacheTransfer: removed
BaseLocator.HTTPServiceOptions: changed from []func(s *github.com/swaggest/rest/web.Service, initialized bool) to []func(s *github.com/swaggest/rest/web.Service)
MakeCacheOf: changed from func(*BaseLocator, string, time.Duration, ...func(cfg *github.com/bool64/cache.FailoverConfigOf[V])) *github.com/bool64/cache.FailoverOf[V] to func(interface{CtxdLogger() github.com/bool64/ctxd.Logger; StatsTracker() github.com/bool64/stats.Tracker}, string, time.Duration, ...func(cfg *github.com/bool64/cache.FailoverConfigOf[V])) *github.com/bool64/cache.FailoverOf[V]
## compatible changes
(*BaseLocator).CacheInvalidationIndex: added
(*BaseLocator).CacheTransfer: added

# github.com/bool64/brick/debug
## incompatible changes
github.com/go-chi/chi/v5.(*Mux).MethodNotAllowedHandler: changed from func() net/http.HandlerFunc to func(...github.com/go-chi/chi/v5.methodTyp) net/http.HandlerFunc
## compatible changes
Config.Middlewares: added

# summary
Inferred base version: v0.2.1
Suggested version: v0.3.0

Copy link

Unit Test Coverage

total: (statements) 56.6%
changed lines: (statements) 48.1%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 48.1%
cache.go 0.0%
cache.go:15 TransferCache 0.0%
cache.go:24 MakeCacheOf 0.0%
cmd.go 0.0%
cmd.go:33 Start 0.0%
debug.go 50.0%
debug.go:20 MountDevPortal 100.0%
debug.go:38 SetupDebugRouter 38.5%
http.go 100.0%
http.go:20 NewBaseWebService 100.0%
init.go 100.0%
init.go:32 NoOpLocator 100.0%
init.go:62 NewBaseLocator 100.0%
locator.go 0.0%
locator.go:43 CacheTransfer 0.0%
locator.go:48 CacheInvalidationIndex 0.0%
debug/config.go no coverage
test/feature.go no coverage
Coverage diff with base branch

Missing base coverage file

@codecov-commenter
Copy link

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (6c5c169) 52.94% compared to head (d382125) 51.62%.
Report is 1 commits behind head on master.

Files Patch % Lines
cache.go 0.00% 14 Missing ⚠️
debug.go 25.00% 2 Missing and 1 partial ⚠️
locator.go 0.00% 2 Missing ⚠️
cmd.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   52.94%   51.62%   -1.32%     
==========================================
  Files          10       11       +1     
  Lines         357      370      +13     
==========================================
+ Hits          189      191       +2     
- Misses        144      155      +11     
  Partials       24       24              
Flag Coverage Δ
unittests 51.62% <35.48%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vearutop vearutop merged commit 0fcf7f3 into master Dec 26, 2023
6 of 7 checks passed
@vearutop vearutop deleted the ptoto-blog-pt2 branch December 26, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants