Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - Send Email with Sendgrid #46

Closed
florentinvintila opened this issue Jan 27, 2022 · 2 comments · Fixed by #47
Closed

Refactor - Send Email with Sendgrid #46

florentinvintila opened this issue Jan 27, 2022 · 2 comments · Fixed by #47
Assignees
@florentinvintila
Labels
enhancement New feature or request project: flow

Comments

@florentinvintila
Copy link
Contributor

Things to improve:

It integrates with Sendgrid and it uses sendgrid/client lib to send the email. Needs to check the response received from Sendgrid, to mark the task if it is a success or not,
An error message must always be present in the logs before closing a task with failure (including when the response from Sendgrid states that the email was not sent, any other non 2xx status).
Validate all the input parameters including the non mandatory ones if they are provided.
Remove the log.sys that outputs the client's apikey.
@florentinvintila florentinvintila added the enhancement New feature or request label Jan 27, 2022
@florentinvintila florentinvintila self-assigned this Jan 27, 2022
florentinvintila added a commit that referenced this issue Jan 31, 2022
@florentinvintila
#46 finished changes for sendEmailWithSendgrid
2fd247d
@florentinvintila florentinvintila mentioned this issue Feb 3, 2022
Merged
florentinvintila added a commit that referenced this issue Feb 3, 2022
@florentinvintila
#46 fixed package-lock
c59567f
@tlawrie
Copy link
Member

tlawrie commented Feb 4, 2022 •
edited

Added to the Flow Project and Release 3.6.2

@tlawrie
Copy link
Member

tlawrie commented Feb 15, 2022

@timrbula to follow up whether this makes it into 3.7.0

florentinvintila added a commit that referenced this issue Feb 17, 2022
@florentinvintila
#46 changes as per request
1005fd6
florentinvintila added a commit that referenced this issue Feb 17, 2022
@florentinvintila
#46 finished changes for sendEmailWithSendgrid
38a18e4
florentinvintila added a commit that referenced this issue Feb 17, 2022
@florentinvintila
#46 fixed package-lock
e76ab88
florentinvintila added a commit that referenced this issue Feb 17, 2022
@florentinvintila
#46 changes as per request
c0fcd96
tlawrie pushed a commit that referenced this issue Feb 17, 2022
@florentinvintila @morarucostel
Feat 46 email sendgrid refactor (#47)
5d8a0cc 
* fix 44

* cleanup

* cleanup

* removed selfsign certificate check

* changes done as per feedback

* small fix

* workaround fix for node 14, < 15

* added libs folder to dockerfile

* small fix

* fix for headers

* added logs + small refactoring

* new logs

* fix + docker local

* reject all other than 2xx

* forgot to push

* regex fail

* added input validations

* fix typo + package update

* force defaults for inputs

* started refactoring

* #46 finished changes for sendEmailWithSendgrid

* refactor

* #46 fixed package-lock

* 49-fix-http-task-headers-split

* #46 changes as per request

* started refactoring

* #46 finished changes for sendEmailWithSendgrid

* merge 1

* #46 fixed package-lock

* #46 changes as per request

Co-authored-by: Vintila Florentin Ovidiu <vfo@Vintilas-MacBook-Pro.local>
Co-authored-by: Moraru Costel <moraru_costel@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florentinvintila florentinvintila

Labels
enhancement New feature or request project: flow
Projects
Boomerang Flow
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat 46 email sendgrid refactor boomerang-io/worker.flow
2 participants
@florentinvintila @tlawrie