Market maker can associate product with supplier and suppliers only see their own products #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2017
pmn4
reviewed
Oct 4, 2017
| if params[:ids] | ||
| @suppliers = Spree::Supplier.accessible_by(current_ability, :read).where(id: params[:ids].split(',')).order(:name) | ||
| else | ||
| @suppliers = Spree::Supplier.accessible_by(current_ability, :read).order(:name).ransack(params[:q]).result |
pmn4
reviewed
Oct 4, 2017
| </div> | ||
| </div> | ||
|
|
||
| <div class="clear"></div> |
|
despite being a lot of code, this is pretty straightforward. |
updates to lock down admin based on user role
* ensures default supplier_admin role is added to the db when extension is
installed and db:seed is run
* reimplements user management to define marketmaker and
supplier_admin based on existing spree_roles vs. checking whether
a user has a supplier and an admin role.
* allows us to create cancan abilities based on spree_roles for
supplier_admin without those users getting abilities that are
defined for the admin role
* only displays supplier field on product edit page when user is a marketmaker
* updates cancan abilities for supplier_admin
kenton
force-pushed
the
kn/market-maker-can-associate-product-with-supplier
branch
from
bf54de2
to
b197dc3
Compare
kenton
deleted the
kn/market-maker-can-associate-product-with-supplier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should take care of issues #20 and #21.
End results is that, as of this PR,
Implemented and lightly tested in the browser, but needs specs updated.
Pushing PR now to get some early eyes on it, but still need to work on those specs.