Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite Anyone 1.4.6 no longer replaces BP's native 'send-invites' in groups #177

Closed
boonebgorges opened this issue Dec 15, 2023 · 1 comment
Closed

Invite Anyone 1.4.6 no longer replaces BP's native 'send-invites' in groups #177

boonebgorges opened this issue Dec 15, 2023 · 1 comment
Milestone
1.4.7

Comments

@boonebgorges
Copy link
Owner

Something about the changes introduced in 1.4.6 for BP 12.0 compat caused IA to no longer replace BP's native send-invites group nav item. Instead, our nav item is placed alongside it. This should be sorted out.
@boonebgorges boonebgorges added this to the 1.4.7 milestone Dec 15, 2023
@boonebgorges
Copy link
Owner Author

I've tracked it to 94a766b. This was a mistake: I thought I was removing a hardcoded IA slug, but really it's a BP slug. This may need a somewhat different approach in order to maintain compatibility with BP 12, but at the very least the changeset should be reverted.

boonebgorges added a commit that referenced this issue Dec 15, 2023
@boonebgorges
Revert "Fix incorrect remove subnav hardcoded slug."
4bb85f8 
This reverts commit 94a766b.

See #177.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.7
Development

No branches or pull requests
1 participant
@boonebgorges