New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate argument 'constraint' in bbs() #36

Closed
sbrockhaus opened this Issue Jun 12, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@sbrockhaus
Member

sbrockhaus commented Jun 12, 2016

As @hofnerb pointed out that bbs() with argument constraint should not be used for decreasing or increasing effects, this argument should be deprecated.
Instead bmono() can be used.

Consider an example where the true function is not monotonic:

library(mboost)

x <- sort(rnorm(100))
y <- x^2
y <- y - mean(y)
dat <- data.frame(y = y, x = x)

m <- mboost(y ~ bbs(x), data = dat)
m_bbs <- mboost(y ~ bbs(x, constraint = "increasing"), data = dat)
m_bmono <- mboost(y ~ bmono(x, constraint = "increasing"), data = dat)

par(mfrow = c(1,3))
plot(m, main = "bbs(x)"); lines(x, y, col=2)
plot(m_bbs, main = "bbs(x, constraint = \"increasing\")"); lines(x, y, col=2)
plot(m_bmono, main = "bmono(x, constraint = \"increasing\")"); lines(x, y, col=2)

@Almond-S

hofnerb added a commit that referenced this issue Jul 26, 2016

hofnerb added a commit that referenced this issue Jul 27, 2016

@hofnerb hofnerb closed this Jul 27, 2016

@hofnerb

This comment has been minimized.

Member

hofnerb commented Jul 28, 2016

We now discourage using bbs(, constraint != "none"); However, we cannot remove this functionality as other code and other packages (ctm) rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment