Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cvrisk( , grid = 0:mstop) #66

Closed
hofnerb opened this issue Jan 27, 2017 · 1 comment
Closed

Allow cvrisk( , grid = 0:mstop) #66

hofnerb opened this issue Jan 27, 2017 · 1 comment

Comments

@hofnerb
Copy link
Member

@hofnerb hofnerb commented Jan 27, 2017

As we are now (see #64) able to fit models with mstop = 0 we should be also able to

  • extract a sensible risk for the offset model.
  • allow cross-validation starting from 0, i.e., allow that no base-learner is selected.
  • Perhaps, we have to fix predict and fitted for an offset model. Currently, a scalar is returned bu actually a constant vector of offsets might be more suitable. However, we then need to make sure that the subset function in mboost_fit works as desired.

The first point might introduce a lot of changes as we cannot assess a vectors zeroth element (hence all risks are shifted by one index). Consequently using the extractor function risk.mboost() might avoid to many changes.

@hofnerb
Copy link
Member Author

@hofnerb hofnerb commented Jan 27, 2017

cvrisk for CoxPH is currently only working for grid = 1:mstop. Atm, it changes the grid if 0 is included and issues a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.