Location #241
Closed
Location #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the filename of the caller
| @@ -1466,10 +1477,23 @@ template <class... Ts, class TEvent> | |||
| struct test { | |||
| utility::string_view type{}; | |||
| utility::string_view name{}; | |||
| reflection::source_location location; | |||
|
|
|||
| constexpr test(std::initializer_list<utility::string_view> l, const reflection::source_location& currentLocation = | |||
There was a problem hiding this comment.
I'm afraid that this solution will always produce ut.hpp as the file_name 🤔 I believe to get it working we have to do it in the callee side, in ""_test in this case.
There was a problem hiding this comment.
Arg, I thought it work due to a cache of another include that filled the filename (it was for another test). I though I removed, but it's seems I didn't. When it worked I just pressumed UDL was simply syntax sugar and that the compiler was really calling the contructor directily (thus with the default value location parameter). Not the case then. Forget about this attempt then :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try at at adding the location information of the caller to the test constructor to be able to have the filename available to the test_begin data structure. Ignore the exception stuff (as it belongs to another PR) and see what you think. Maybe the initializer list can became a variadic template. But before I improve this, I wanna to see if this is an agreeable path forward.