Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 [CMake] boost.ut alias #433

Closed
wants to merge 1 commit into from

Conversation

krzysztof-jusiak
Copy link
Contributor

Problem:

  • boost.ut and ut are used by users but only ut is exposed.

Solution:

  • Add boost.ut alias for ut.

Problem:
- boost.ut and ut are used by users but only ut is exposed.

Solution:
- Add boost.ut alias for ut.
@claremacrae
Copy link
Contributor

claremacrae commented Mar 20, 2021

Thanks for looking in to this.

I think this would fix builds for people who link against the boost.ut, and don't change any options in that target.

However, I found that when I made boost.ut be an alias, my code like this till failed - with an error that it wasn't legal to set up target_compile_options for an alias.:

if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
    # Turn off some checks off for boost.ut
    target_compile_options(boost.ut INTERFACE
            -Wno-c99-extensions # Needed for Boost.ut, at least in v1.1.6
            -Wno-documentation-unknown-command # unknown command tag name \userguide
            -Wno-weak-vtables
            -Wno-comma # See https://github.com/boost-ext/ut/issues/398
            )
endif()

So for maximum backward compatibility, I think the original target name of boost.ut would need to be retained.

@krzysztof-jusiak
Copy link
Contributor Author

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants