KMeans 중심값 생성 함수 추가 (BallCut) #37
Conversation
| let distance = maxX - minX | ||
| let coverage = distance / 3 | ||
|
|
||
| let result = kmm.initializeDistanceCentroids(k: 13, coverage: coverage, coordinates: centroids) |
There was a problem hiding this comment.
함수명 달라진 것 같은데 괜찮나요??
There was a problem hiding this comment.
안괜찮아요! ㅋㅋㅋㅋㅋ 수정한 부분 커밋이 PR에 포함이안된것 같네요 죄송합니다
| return centroids | ||
| } | ||
|
|
||
| var remove: [Coordinate] = [] |
There was a problem hiding this comment.
여기 변수명 바꿔줘야 할 것 같아요!
There was a problem hiding this comment.
indexForRemoveCentroids 어떨까요...?
There was a problem hiding this comment.
removeCoordinates로 수정했습니다!
There was a problem hiding this comment.
indexForRemoveCentroids 어떨까요...?
index를 담는 배열이 아니에요!!
| var centroids: [Coordinate] = [] | ||
| let container = createContainer(k: k, coordinates: coordinates) | ||
| centroids += pickCentroids(k: k, distance: coverage, container: container) | ||
|
|
There was a problem hiding this comment.
nit : var centroids = pickCentroids(k: k, distance: coverage, container: container)
이렇게 하는건 어떤가용 ??
|
|
||
| let topLeft = Coordinate(x: Mock.minX, y: Mock.maxY) | ||
| let bottomRight = Coordinate(x: Mock.maxX, y: Mock.minY) | ||
| let centroids = kmm.screenCentroids(topLeft: topLeft, bottomRight: bottomRight) |
There was a problem hiding this comment.
넵.. 바로 수정했습니다! 😅
| @discardableResult | ||
| private func kmeansByRandom(k: Int, coords: [Coordinate]) -> [Cluster] { | ||
| let kmm = KMeans(k: 22) | ||
| let centroids = kmm.randomCentroids(rangeOfLat: Mock.minY...Mock.maxY, |
- 중심값 생성 함수들을 프로토콜로 분리후 주입하여 사용할 수 있도록 변경
…com/boostcamp-2020/Project17-C-Map into feature/kmeans/initialize-centroids
| func centroids() -> [Coordinate] { | ||
| let result: [Coordinate] = recursiveClassify(k: k, coordinates: points) | ||
|
|
||
| return result | ||
| } |
There was a problem hiding this comment.
return recursiveClassify(k: k, coordinates: points) 로 줄일 수 있을거 같아용
| var centroids: [Coordinate] = [] | ||
| let container = createContainer(k: k, coordinates: coordinates) | ||
| centroids += pickCentroids(k: k, distance: coverage, container: container) |
There was a problem hiding this comment.
여기두 var centroids = pickCentroids(k: k, distance: coverage, container: container) 가 어떤지용
| let container = createContainer(k: k, coordinates: coordinates) | ||
| centroids += pickCentroids(k: k, distance: coverage, container: container) | ||
|
|
||
| if centroids.count != k { |
| private func createContainer(k: Int, coordinates: [Coordinate]) -> [Coordinate] { | ||
| var coordinates = coordinates | ||
| var container: [Coordinate] = [] | ||
| let mutiplier: Int = 5 |
There was a problem hiding this comment.
매직넘버라면 전역으로 선언하는게 관리하기 편하지않을까용,,?
| var removeCoordinates: [Coordinate] = [] | ||
|
|
||
| container.forEach { coordinate in | ||
| if centroid.distanceTo(coordinate) <= distance { | ||
| removeCoordinates.append(coordinate) | ||
| } | ||
| } | ||
|
|
||
| container = container.filter { !removeCoordinates.contains($0) } |
There was a problem hiding this comment.
이부분
container = container.filter { centroid.distanceTo($0) >= distance } 로 줄일 수 있을 거 같아용! 아닌가요,,?
|
|
||
| import Foundation | ||
|
|
||
| final class BallCutCentroidGenerator: CentroidCreatable { |
There was a problem hiding this comment.
제가 보기엔 모두 순수함수로 작성하셔서 struct도 괜찮을거같은데 어떠신가요??
There was a problem hiding this comment.
이부분은 의논을 해보죠. 매니저 클래스 만들고 결정해봐야할 것 같아요!
세세하게 봐줘서 고마워요! |
토요일에도 리뷰를 달아주셔서 감사합니다! 퍼포먼스 비교하는 부분은 아직 작성중이라서 일부러 빼놨는데 프로젝트파일에 포함되어있었나보네요 😂 |
구현내용
BallCut Algorithm
[참고자료]
https://lovit.github.io/nlp/machine%20learning/2018/03/19/kmeans_initializer/
논의사항
coverage distance 값 결정
화면 (선택)