Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] add train/valid split code #34

Merged
merged 2 commits into from
Apr 19, 2022
Merged

[Feat] add train/valid split code #34

merged 2 commits into from
Apr 19, 2022

Conversation

yehyunsuh
Copy link
Contributor

@yehyunsuh yehyunsuh commented Apr 19, 2022 •
edited

Motivation ๐Ÿค”

  • ICDAR2017 ๋ฐ์ดํ„ฐ๋ฅผ ๋‹ค์šด ๋ฐ›๊ณ , ์ด๋ฅผ unzipํ•˜์—ฌ, ์šฐ๋ฆฌ๊ฐ€ ์›ํ•˜๋Š” ๋ฐ์ดํ„ฐ๋งŒ ์ถ”์ถœํ•˜๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

Key Changes ๐Ÿ”‘

  • convert_mlp.py ํŒŒ์ผ์—์„œ ๊ธฐ์กด์—๋Š” ์ „์ฒด ICDAR2017 ๋ฐ์ดํ„ฐ๋ฅผ train dataset์œผ๋กœ ์‚ฌ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ, validation ๊ณผ์ •๋„ ํ•„์š”ํ–ˆ๊ธฐ ๋•Œ๋ฌธ์—, ์ด๋ฅผ ๋‚˜๋ˆ„๋Š” ๊ณผ์ •์„ ์ง„ํ–‰ํ•  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

To Reviewers ๐Ÿ™

  • conflict๋Š” ์—†๋Š” ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค. ์ฐธ๊ณ ์‚ฌํ•ญ์€ ์•„๋ž˜์— ํƒœ๊ทธ๋กœ ์ „๋ถ€ ๋‹ฌ์•„๋†“๊ฒ ์Šต๋‹ˆ๋‹ค.

resolves: #17 #18 #21
references: #20

@yehyunsuh yehyunsuh added the enhancement New feature or request label Apr 19, 2022
@yehyunsuh yehyunsuh added this to In progress in Data Annotation via automation Apr 19, 2022
@yehyunsuh yehyunsuh self-assigned this Apr 19, 2022
@yehyunsuh yehyunsuh moved this from In progress to Review in progress in Data Annotation Apr 19, 2022
@seoulsky-field
Copy link
Contributor

ํ•„์š”ํ–ˆ์—ˆ๋˜ ์ฝ”๋“œ๋„ค์š”! ์ถ”๊ฐ€ํ•ด ์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค :) ์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค! LGTM!!

@seoulsky-field seoulsky-field merged commit 5ed23b5 into develop Apr 19, 2022
Data Annotation automation moved this from Review in progress to Done Apr 19, 2022
@seoulsky-field seoulsky-field changed the title Yehyun [Feat] add train/valid split code Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seoulsky-field seoulsky-field Awaiting requested review from seoulsky-field

Assignees

@yehyunsuh yehyunsuh

Labels
enhancement New feature or request
Projects
Data Annotation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yehyunsuh @seoulsky-field