-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[팀 생성/ 팀 설정 페이지] UI 개발 #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
유저 아이콘 클릭 이벤트 추가
유저 아이콘 클릭 이벤트 추가
- 라우팅 추가 - 기본 헤더, page/template 추가
팀 생성 컨테이너 UI 개발함 UI만 개발했기 때문에 이벤트는 존재하지 않음 공통으로 사용할 수 있는 INPUTLABEL.TSX 구현
…-2021/web10-CowDogTing into Feat/TeamSettingPage
팀 생성 페이지에서 재 사용
영진 작업 완료 까지 일단 컨테이너만 생성해 놓음
[Feat/my page] Mypage UI
팀 생성 컨테이너 UI 개발함 UI만 개발했기 때문에 이벤트는 존재하지 않음 공통으로 사용할 수 있는 INPUTLABEL.TSX 구현
팀 생성 페이지에서 재 사용
영진 작업 완료 까지 일단 컨테이너만 생성해 놓음
jin-Pro
reviewed
Nov 4, 2021
function TeamCreateIcon() { | ||
return ( | ||
<Link to="/teamCreate"> | ||
<svg css={TeamCreateIconStyle} width="349" height="282" viewBox="0 0 349 282" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
div 태그에 background 넣는게 낫지않아???
<InputLabel label="팀명" /> | ||
<InputLabel label="소개" /> | ||
<InputLabel label="가능시간" /> | ||
<InputLabel label="지역" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
차라리 children으로 넣는 것 보다 TeamInfoContainer 내부에서 InputLabel을 호출해서 사용하는게 낫지 않을까
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
작업 대기
특이 사항
1. 팀 설정 페이지 / 팀 생성 페이지가 서로 재사용이 많이되어서 팀 설정페이지 브랜치로 함께 작업하였음
2. label - input 을 재사용 하기위해 재사용 가능한 InputLabel.tsx 파일을 하나 생성
질문