-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 프로필 수정 API #134
[Feature] 프로필 수정 API #134
Conversation
- Put API - myinfo service 호출 - swagger decorator
constructor( | ||
message = '중복된 유저이름으로 요청했습니다! 해당 유저이름으로 바꿀 수 없습니다.', | ||
) { | ||
super({ status: 'USER_NAME_BAD_REQUEST', message }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USER_NAME_BAD_REQUEST가 중복된 유저에 대한 내용인지 알기 힘든 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
- Exception 이름 변경
- 회원탈퇴했을 경우 탈퇴한 유저의 userName을 다른 유저가 사용할 수 있도록 로직을 변경
- 인자 값을 객체로 넘기자!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
체크 리스트
작업 내역
고민
꼭 Request DTO를 풀어헤쳐서 Service에 넘겨야하는가?
위를 이어서.. 공부
toEntity()
메소드를 이용해 새로운 인스턴스를 반환해주는 모습이다. 참고할만 하다.비고