[Feature] 모집 완료 API 추가하기 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 작성자가 아니면 NotAuthorException 반환 - 모집중인 게시글이 아니면 NotProgressGroupException 반환 - 모집 게시글이 존재하지 않으면 GroupArticleNotFoundException 반환
2 tasks
username1103
requested review from
sxungchxn,
pythonstrup and
kong430
and removed request for
sxungchxn
pythonstrup
reviewed
Nov 30, 2022
Comment on lines
-57
to
60
| if (this.userId !== user.id) { | ||
| if (!this.isAuthor(user)) { | ||
| throw new NotAuthorException(); | ||
| } |
There was a problem hiding this comment.
비교 구문을 따로 뺀 이유가 있나요? isAuthor 함수를 재사용하는 부분이 있을까요?
There was a problem hiding this comment.
@pythonstrup 모집취소나 모집 수정등 자주 사용될 로직으로 생각해 분리했습니다. 그리고 단순히 userId를 비교하는 것만 봤을 때, 행위가 어떤 행위인지 코드 이해도가 없는 사람을 알 수 없기 때문에 이름을 작성자인지 확인하는 과정임을 나타낼 수 있다고 생각했어요.
Comment on lines
+80
to
+82
| const categories = await this.groupCategoryRepository.find({ | ||
| where: { deletedAt: null }, | ||
| }); |
There was a problem hiding this comment.
controller에서 service를 통하지 않고 바로 repository를 호출한 이유가 있을까요??
약간 생소하네요..?!?
There was a problem hiding this comment.
@pythonstrup 로직없이 단순히 조회해서 바로 응답해주는 부분이라 굳이 서비스를 거치지 않아도 될 것이라고 생각했어요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크 리스트
작업 내역
POST /v1/group-articles/:id/recruitment-complete 모집완료 API 제작NotProgressGroupException을 반환한다.NotAuthorException을 반환한다.GroupArticleNotFoundException을 반환한다.문제 상황과 해결
비고