[Feature] 모임 신청자 조회하기 API #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 경로 추가 - swagger 작성 - dto 적용
2 tasks
username1103
reviewed
Dec 1, 2022
Comment on lines
+117
to
+129
| private async getApplicationWithUserInfo(group: Group) { | ||
| const allApplication = | ||
| await this.groupApplicationRepository.findAllApplicationByGroup(group.id); | ||
|
|
||
| const applicationWithUserInfoList = allApplication.map( | ||
| async (application) => { | ||
| const user = await application.user; | ||
| return ApplicationWithUserInfoResponse.from( | ||
| UserInfo.from(user), | ||
| application, | ||
| ); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
위와 같은 상태에서는 N+1 Problem이 발생할 것 같습니다.
현재 순서가 해당 모집게시글의 모집 신청 정보들을 가져오고 각각 정보들에 맞는 유저 데이터를 가져오는데 이렇게되면 신청한 유저수가 N명이면 N+1개의 쿼리가 발생하게 될 것 같아요.
처음에 조회해 올 때 부터 함께 조회해오도록 수정하면 어떨까요?
There was a problem hiding this comment.
학습하고 반영했습니다!
감사합니다!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크 리스트
작업 내역